question about drivers/rtc/rtc-cmos.c

From: Julia Lawall
Date: Wed Dec 25 2013 - 14:32:45 EST

The function cmos_do_probe contains the code:

if (is_hpet_enabled()) {
int err;

rtc_cmos_int_handler = hpet_rtc_interrupt;
err = hpet_register_irq_handler(cmos_interrupt);
if (err != 0) {
dev_warn(dev, "hpet_register_irq_handler "
" failed in rtc_init().");
goto cleanup1;

Is it intentional that the error code returned by
hpet_register_irq_handler is put ina local variable that will not be seen
at label cleanup1? The return value is retval, which is 0 at this point.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at