Re: [PATCH] drm/i915: Fix refcount leak and possible NULL pointerdereference.

From: Chris Wilson
Date: Wed Dec 25 2013 - 16:53:36 EST

On Tue, Dec 24, 2013 at 08:50:23PM +0900, Tetsuo Handa wrote:
> >From 482be6384379072eb4c0d45d0ab8a25df4f59ed7 Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Date: Tue, 24 Dec 2013 18:04:14 +0900
> Subject: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference.
> Since get_pid_task() grabs a reference on the task_struct, we have to drop the
> refcount after reading that task's comm name. Also, directly reading like
> get_pid_task()->comm can trigger an oops when get_pid_task() returned NULL.

The second issue is moot as file itself cannot exist if the task_struct
is NULL, and the task_struct cannot be destroyed until we finish the
function. The simpler fix would appear to be s/get_pid_task/pid_task/

Chris Wilson, Intel Open Source Technology Centre
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at