Re: [PATCH 1/1] reiserfs:Adding tmpfile support
From: Christoph Hellwig
Date: Thu Dec 26 2013 - 04:02:38 EST
On Wed, Dec 25, 2013 at 02:39:48PM +0100, Richard Weinberger wrote:
> On Wed, Dec 25, 2013 at 2:23 PM, Fabian Frederick <fabf@xxxxxxxxx> wrote:
> > This patch is largely based on reiserfs_create function.
> > -Removing dquot_initialize (cf ext2/tmpfile)
> > -Removing add_entry code.
> > -Adding d_tmpfile generic call.
> > It was not extensively tested; other solutions would
> > be to work with hidden entries or merge
> > creation - tmpfile process.
> Is it worth adding new features to a legacy file system like reiserfs?
Having user API parity is always a good thing, especially if it doesn't
require on-disk format changes. Same case as FIEMAP or
SEEK_DATA/SEEK_HOLE to mention some recent features.
That being said this needs to follow them model of ext3/ext3/xfs and
add the inode to the unlink/orphan inode list on tmpfile creation and
move it out on flink.
We'll also need a proper verifier for the expected behaviour, which I
hope we'll get out of the work in progress XFS support.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/