Re: [PATCH] clk: support hardware-specific debugfs entries

From: Gerhard Sittig
Date: Thu Dec 26 2013 - 09:51:03 EST

On Thu, Dec 26, 2013 at 08:26 -0600, Alex Elder wrote:
> @@ -140,6 +147,9 @@ struct clk_ops {
> int (*set_rate)(struct clk_hw *hw, unsigned long,
> unsigned long);
> void (*init)(struct clk_hw *hw);
> + int (*debug_init)(struct clk_hw *hw, struct dentry *dentry);
> +#endif
> };

Please note that this CONFIG_COMMON_CLK_DEBUG switch may go away
(or get replaced) soon. Mike plans to effectively enable common
clock debugging as soon as debugfs is in effect (which I welcome
very much).

So you should monitor current development and adjust your patch,
or be prepared for breakage and fixing afterwards. I'd suggest
to just declare the .debug_init member unconditionally now.
Since Mike's patch very likely gets accepted, and nothing will
break when yours gets added later (regardless of the number of
review iterations it will see).

virtually yours
Gerhard Sittig
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@xxxxxxx
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at