Re: [PATCH net-next 4/6] r8152: add rtl_ops

From: David Miller
Date: Fri Dec 27 2013 - 12:28:20 EST

From: Hayes Wang <hayeswang@xxxxxxxxxxx>
Date: Fri, 27 Dec 2013 10:34:08 +0800

> +static int rtl_ops_init(struct r8152 *tp, const struct usb_device_id *id)
> + if (rtl_ops_init(tp, id)) {
> + netif_err(tp, probe, netdev, "Unknown Device");
> + return -ENODEV;

You're completely ignoring the error code returned from rtl_ops_init()
(which, as an aside, uses -EFAULT which doesn't seem all that

You might as well have rtl_ops_init() return a boolean.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at