Re: [PATCH 05/38] sparc: kernel: add missing put_device call
From: David Miller
Date: Fri Dec 27 2013 - 12:43:17 EST
From: Levente Kurusa <levex@xxxxxxxxx>
Date: Thu, 19 Dec 2013 16:03:16 +0100
> This is required so that we give up the last reference to the device.
> The kfree() has been removed because put_device will set the underlying kref's
> reference count to zero and hence vio_dev_release will get called resulting in
> kfreeing the structure.
> Signed-off-by: Levente Kurusa <levex@xxxxxxxxx>
There is no reference held to vdev->dev at this point, that's why
we should directly kfree() it and put_device() is not appropriate.
Pretty much all of your patches have this problem.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/