Re: [PATCH v4 01/15] usb: phy: msm: Move mach dependent code toplatform data
From: Felipe Balbi
Date: Fri Dec 27 2013 - 13:45:48 EST
On Fri, Dec 27, 2013 at 10:23:10AM -0800, Stephen Boyd wrote:
> On 12/27/13 10:10, Felipe Balbi wrote:
> > Hi,
> > On Tue, Nov 12, 2013 at 04:51:36PM +0200, Ivan T. Ivanov wrote:
> >> From: "Ivan T. Ivanov" <iivanov@xxxxxxxxxx>
> >> This patch fix compilation error when driver is compiled
> >> in multi-platform builds.
> >> drivers/built-in.o: In function `msm_otg_link_clk_reset':
> >> ./drivers/usb/phy/phy-msm-usb.c:314: undefined reference to `clk_reset'
> >> ./drivers/usb/phy/phy-msm-usb.c:318: undefined reference to `clk_reset'
> >> Use platform data supplied reset handlers and adjust error
> >> messages reported when reset sequence fail.
> >> This is an intermediate step before adding support for reset
> >> framework and newer targets.
> >> Signed-off-by: Ivan T. Ivanov <iivanov@xxxxxxxxxx>
> >> Acked-by: David Brown <davidb@xxxxxxxxxxxxxx>
> >> Cc: Daniel Walker <dwalker@xxxxxxxxxx>
> >> Cc: Felipe Balbi <balbi@xxxxxx>
> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > this really looks like you should be using reset framework
> > (drivers/reset/), then your phy driver would simply reset_assert() and
> > reset_deassert().
> Unfortunately the reset framework is a DT only framework and there are
> still non-DT platforms within mach-msm. Arnd suggested we push the
> non-DT reset code down into the mach directory in the meantime. We're in
> the process of adding the reset framework to DT enabled MSM platforms,
> hopefully those get merged in 3.14.
And this is why the ARM port is in such a messy situation. It's always
better to "push things into the mach- directory" than improving existing
frameworks to cope with wild ARM SoCs.
fell free to push this through your tree. It _does_ make the PHY driver
slightly better and probably buildable on other arches with
Still, I *really* want to see this switching over to reset framework on
ps: for this patch only you can have my
Acked-by: Felipe Balbi <balbi@xxxxxx>
Description: Digital signature