Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()

From: Prarit Bhargava
Date: Sat Dec 28 2013 - 10:59:15 EST




On 12/27/2013 08:07 PM, H. Peter Anvin wrote:
> On 12/27/2013 08:13 AM, Prarit Bhargava wrote:
>>>
>>> Back to my question, assume cpu1 will be off-lined and one irq affinity is
>>> set as (1, 2) -- this irq will be bypassed. Looks good. But if one irq
>>> affinity is set as only (1), -- this irq is bypassed, too. Not right!
>>
>> Oh, yes, this is a bug. ... and as you point out ...
>>
>
> Does this mean the patch that is currently in my tree should not be
> pushed to Linus? It sounds like that to me...

Yes, hpa -- please drop the patch. I will resubmit an updated patch after testing.

P.

>
> -hpa
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/