[PATCH 3.2 061/185] devpts: plug the memory leak in kill_sb
From: Ben Hutchings
Date: Sat Dec 28 2013 - 21:29:11 EST
3.2.54-rc1 review patch. If anyone has any objections, please let me know.
From: Ilija Hadzic <ihadzic@xxxxxxxxxxxxxxxxxxxxxx>
commit 66da0e1f9034140ae2f571ef96e254a25083906c upstream.
When devpts is unmounted, there may be a no-longer-used IDR tree hanging
off the superblock we are about to kill. This needs to be cleaned up
before destroying the SB.
The leak is usually not a big deal because unmounting devpts is typically
done when shutting down the whole machine. However, shutting down an LXC
container instead of a physical machine exposes the problem (the garbage
is detectable with kmemleak).
Signed-off-by: Ilija Hadzic <ihadzic@xxxxxxxxxxxxxxxxxxxxxx>
Cc: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
fs/devpts/inode.c | 1 +
1 file changed, 1 insertion(+)
@@ -413,6 +413,7 @@ static void devpts_kill_sb(struct super_
struct pts_fs_info *fsi = DEVPTS_SB(sb);
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/