Re: [PATCH net-next v2 20/20] net: caif: slight optimization of addrcompare
From: Ding Tianhong
Date: Sun Dec 29 2013 - 21:17:45 EST
On 2013/12/29 1:04, Joe Perches wrote:
> On Sat, 2013-12-28 at 23:02 +0800, Ding Tianhong wrote:
>> ä 2013/12/28 14:59, Joe Perches åé:
>>> On Sat, 2013-12-28 at 14:18 +0800, Ding Tianhong wrote:
>>>> Use possibly more efficient ether_addr_equal
>>>> to instead of memcmp.
>>> This may be a distinction without difference, but
>>> is a CAIF seghead also an ethernet address?
>> NOïthis is a coincidence, the CAIF seghead is 6 bytes too,
>> So from a logical point of view, maybe a new function with
>> suitable name will be more reasonable here, but the name of
>> ether_addr_equal is not correctly here.:)
> So please remove this one from the series.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/