Re: [PATCH net-next v2 11/20] net: packetengines: slightoptimization of addr

From: Joe Perches
Date: Mon Dec 30 2013 - 01:05:36 EST

On Mon, 2013-12-30 at 10:39 +0800, Ding Tianhong wrote:
> I don't understand packetengine NIC anymore, But I think the change is clearly,
> as your said, the broadcast check is enough here, did you mean that?
> !is_broadcast_ether_addr((u8 *)(le32_to_cpu(yp->rx_ring_dma) +
> entry * sizeof(struct yellowfin_desc)))

Not quite. I meant this could be:

u8 *addr = (u8 *)(unsigned long)le32_to_cpu(yp->rx_ring_dma) +
entry * sizeof(struct yellowfin_desc);

if (!ether_addr_equal(addr, dev->dev_addr) &&
!is_broadcast_ether_addr(addr)) {

but again, I think thus hardly matters and could just as well
be left alone.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at