Re: [PATCH net-next v3 04/19] net: enic: slight optimization of addrcompare

From: Govindarajulu Varadarajan
Date: Mon Dec 30 2013 - 03:22:25 EST

On Mon, 30 Dec 2013, Ding Tianhong wrote:

Use possibly more efficient ether_addr_equal
to instead of memcmp.

Cc: Christian Benvenuti <benve@xxxxxxxxx>
Cc: Sujith Sankar <ssujith@xxxxxxxxx>
Cc: Govindarajulu Varadarajan <govindarajulu90@xxxxxxxxx>
Cc: Neel Patel <neepatel@xxxxxxxxx>
Cc: Nishank Trivedi <nistrive@xxxxxxxxx>
Signed-off-by: Ding Tianhong <dingtianhong@xxxxxxxxxx>
drivers/net/ethernet/cisco/enic/enic_pp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cisco/enic/enic_pp.c b/drivers/net/ethernet/cisco/enic/enic_pp.c
index 43464f0..e6a8319 100644
--- a/drivers/net/ethernet/cisco/enic/enic_pp.c
+++ b/drivers/net/ethernet/cisco/enic/enic_pp.c
@@ -162,7 +162,7 @@ static int enic_are_pp_different(struct enic_port_profile *pp1,
return strcmp(pp1->name, pp2->name) | !!memcmp(pp1->instance_uuid,
pp2->instance_uuid, PORT_UUID_MAX) |
!!memcmp(pp1->host_uuid, pp2->host_uuid, PORT_UUID_MAX) |
- !!memcmp(pp1->mac_addr, pp2->mac_addr, ETH_ALEN);
+ !ether_addr_equal(pp1->mac_addr, pp2->mac_addr);

static int enic_pp_preassociate(struct enic *enic, int vf,

looks good for me

Acked-by: Govindarajulu Varadarajan <govindarajulu90@xxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at