Re: [PATCH] ASoC: generic: add generic compound card with DT support
From: Mark Brown
Date: Tue Dec 31 2013 - 07:00:20 EST
On Tue, Dec 31, 2013 at 11:31:38AM +0100, Jean-Francois Moine wrote:
> This code was first developped on the generic simple card, but its
> recent DT extension cannot be easily extended again to support compound
> cards as the one in the Cubox.
It would have been useful to have provided that feedback at the time
rather than waiting until after it had been merged - it was in review
for long enough. It would also be good to articulate the issues with
the binding rather than simply stating they exist, and to consider
adding a second binding to the existing generic card rather than adding
a totally new card.
Please also remember that all DT patches need to be reviewed by the DT
people, you've not CCed either them or the list.
> + - front-end or back-end: present if the DAI link describes resp.
> + a front-end CPU DAI or a back-end CODEC DAI
These are Linux-internal concepts which shouldn't appear in a DT binding
or at the very least need definition. One thing to consider here is
that these things are all about the internals of a SoC and you'd
therefore expect that they would be defined separately from the card so
as to avoid having to replicate information in every card using a given
Description: Digital signature