Re: [PATCH v1 1/5] block: blk-mq: avoid initializing request duringits completion

From: Jens Axboe
Date: Tue Dec 31 2013 - 11:38:58 EST

On Thu, Dec 26 2013, Ming Lei wrote:
> One problem is that request->start_time/start_time_ns could be
> set as wrong.
> Also it is normal to intialize one data structure just after its
> allocation.
> So move the initialization out of its completion path.

It's done that way because of presumed cache hotness on completion,
since we just touched a lot of the members. Lets just fix the start time
issue by itself.

Jens Axboe

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at