Re: [PATCH] at91: ohci: fixed broken sanity check

From: boris brezillon
Date: Tue Dec 31 2013 - 12:26:12 EST

Hello Jean-Jacques,

On 31/12/2013 17:33, jjhiblot@xxxxxxxxxxxxxxx wrote:
From: jean-jacques hiblot <jean-jacques.hiblot@xxxxxxxx>

The test (pdev->resource[1].flags != IORESOURCE_IRQ) is broken because the flags
value may contain not only the information IORESSOURCE_IRQ but also the IRQ type

This is already fixed: we moved to platform_get_irq and
platform_get_ressource instead of directly accessing platform
resource table.


This solves both the problem you're reporting and another problem when
resources are in a different order (nothing guarantees the resources
order when using DT).

Best Regards,


Signed-off-by: Jean-Jacques Hiblot <jjhiblot@xxxxxxxxxxxxxxx>
drivers/usb/host/ohci-at91.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/ohci-at91.c b/drivers/usb/host/ohci-at91.c
index 418444e..df9c8a4 100644
--- a/drivers/usb/host/ohci-at91.c
+++ b/drivers/usb/host/ohci-at91.c
@@ -142,8 +142,8 @@ static int usb_hcd_at91_probe(const struct hc_driver *driver,
return -ENODEV;

- if ((pdev->resource[0].flags != IORESOURCE_MEM)
- || (pdev->resource[1].flags != IORESOURCE_IRQ)) {
+ if (!(pdev->resource[0].flags & IORESOURCE_MEM)
+ || !(pdev->resource[1].flags & IORESOURCE_IRQ)) {
pr_debug("hcd probe: invalid resource type\n");
return -ENODEV;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at