Re: [PATCH net-next v3 00/19] slight optimization of addr comparefor net modules

From: David Miller
Date: Tue Dec 31 2013 - 16:49:18 EST

From: Ding Tianhong <dingtianhong@xxxxxxxxxx>
Date: Mon, 30 Dec 2013 15:40:25 +0800

> This is the second patchset for slight optimization of address compare,
> mainly for net tree, just following the Joe's opinion, it will help review
> the code for maintainers and supports.
> v2: Change some style for patch 2.
> According Eric's suggestion, use the ether_addr_equal_64bits to instead
> of ether_addr_equal for patch 19.
> In fact, there are a lot of places which could use ether_addr_equal_64bits
> to instead of ether_addr_equal, but not this time, thanks for Joe's
> opinion.
> v3: Change some style for patch 11/19:
> (net: packetengines: slight optimization of addr compare).
> Joe pointed out that is_broadcast_ether_addr(addr) would be appropriate here,
> but this should be left alone and not in this patch, so fix it later.
> In the patch (net: caif: slight optimization of addr compare), the operand for
> memcmp is not mac address, so it is unsuitable to use the ether_addr_equal
> to compare a non mac address, so remove the patch from the series.

Series applied, thanks.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at