Re: [PATCH] Input: cros_ec_keyb - switch from using uint8_t to u8
From: Doug Anderson
Date: Thu Jan 02 2014 - 11:12:16 EST
On Tue, Dec 31, 2013 at 11:34 AM, Dmitry Torokhov
> u8 is proper in-kernel type for unsigned byte data.
I won't say that I keep up with all the latest trends here, but this
surprised me so I did some research. My findings don't agree with
your statement. Perhaps there are different standards that are used
for the input subsystem?
Specifically looking at
<https://www.kernel.org/doc/Documentation/CodingStyle>, I see:
Therefore, the Linux-specific 'u8/u16/u32/u64' types and their
signed equivalents which are identical to standard types are
permitted -- although they are not mandatory in new code of your
When editing existing code which already uses one or the other set
of types, you should conform to the existing choices in that code.
That makes it sound like the author of that document would prefer
uint8_t but will accept u8. It also seems like if code is consistent
about using a given type (as this code is) that it shouldn't be
I'm always happy to be enlightened, though!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/