Re: [Xen-devel] [PATCH] arm64/xen: redefine xen_remap on arm64
From: Stefano Stabellini
Date: Fri Jan 03 2014 - 08:19:59 EST
On Mon, 30 Dec 2013, Wei Liu wrote:
> On Mon, Dec 30, 2013 at 6:55 AM, Chen Baozi <baozich@xxxxxxxxx> wrote:
> > xen_remap used to be defined as ioremap_cached on arm64. In commit
> > c04e8e2fe, a new ioremap_cache was implemented, and ioremap_cached
> > was deleted, while xen_remap stays the same. This would lead to
> > the failure when building with CONFIG_HVC_XEN. Redefined xen_remap
> > on arm64 as ioremap_cache on arm64 to fix it.
> > Signed-off-by: Chen Baozi <baozich@xxxxxxxxx>
> > ---
> > arch/arm/include/asm/xen/page.h | 4 ++++
> > 1 file changed, 4 insertions(+)
> > diff --git a/arch/arm/include/asm/xen/page.h b/arch/arm/include/asm/xen/page.h
> > index 75579a9..b3368df 100644
> > --- a/arch/arm/include/asm/xen/page.h
> > +++ b/arch/arm/include/asm/xen/page.h
> > @@ -117,6 +117,10 @@ static inline bool set_phys_to_machine(unsigned long pfn, unsigned long mfn)
> > return __set_phys_to_machine(pfn, mfn);
> > }
> > +#ifdef CONFIG_ARM64
> > +#define xen_remap(cookie, size) ioremap_cache((cookie), (size))
> > +#else
> > #define xen_remap(cookie, size) ioremap_cached((cookie), (size));
> Looks like there's an redundant semicolon in the original implementation.
Well spotted. We can fix this separately.
Do you want to send a patch for it?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/