Re: [PATCH] scripts/gcc-version.sh: handle CC="gcc -m32"

From: Michal Marek
Date: Fri Jan 03 2014 - 15:34:46 EST


On 3.1.2014 18:10, Michal Marek wrote:
> On 2013-12-10 08:13, Rusty Russell wrote:
>> Without it we get ugly warnings (though build still succeeds).
>>
>> $ make -j8 CC="gcc -m32"
>> In file included from <command-line>:0:0:
>> /usr/include/stdc-predef.h:30:26: fatal error: bits/predefs.h: No such file or directory
>> #include <bits/predefs.h>
>> ^
>> compilation terminated.
>> In file included from <command-line>:0:0:
>> /usr/include/stdc-predef.h:30:26: fatal error: bits/predefs.h: No such file or directory
>> #include <bits/predefs.h>
>> ^
>> compilation terminated.
>> /home/rusty/devel/kernel/linux/scripts/gcc-version.sh: line 31: printf: #: invalid number
>> /home/rusty/devel/kernel/linux/scripts/gcc-version.sh: line 31: printf: #: invalid number
>> /bin/sh: 1: [: 0001: unexpected operator
>> CHK include/config/kernel.release
>> CHK include/generated/uapi/linux/version.h
>> make[1]: Nothing to be done for `all'.
>> ...
>>
>> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
>>
>> diff --git a/scripts/gcc-version.sh b/scripts/gcc-version.sh
>> index 7f2126df91f2..d48b0cbaf246 100644
>> --- a/scripts/gcc-version.sh
>> +++ b/scripts/gcc-version.sh
>> @@ -14,7 +14,7 @@ if [ "$1" = "-p" ] ; then
>> shift;
>> fi
>>
>> -compiler="$*"
>> +compiler="$1"
>
> But this will break things like CC="ccache gcc". Your problem is that
> you do not have the 32bit glibc headers, right?

BTW, what is the usecase for CC="gcc -m32"? AFAICS, at least x86 and
powerpc do this for you when building a 32bit kernel.

Thanks,
Michal

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/