Re: [PATCH] mm/mlock: fix BUG_ON unlocked page for nolinear VMAs

From: Andrew Morton
Date: Fri Jan 03 2014 - 18:56:35 EST


On Sat, 04 Jan 2014 00:36:18 +0100 Vlastimil Babka <vbabka@xxxxxxx> wrote:

> On 01/03/2014 09:52 PM, Linus Torvalds wrote:
> > On Fri, Jan 3, 2014 at 12:17 PM, Sasha Levin <sasha.levin@xxxxxxxxxx> wrote:
> >>
> >> Ping? This BUG() is triggerable in 3.13-rc6 right now.
> >
> > So Andrew suggested just removing the BUG_ON(), but it's been there
> > for a *long* time.
>
> Yes, Andrew also merged this patch for that:
> http://ozlabs.org/~akpm/mmots/broken-out/mm-remove-bug_on-from-mlock_vma_page.patch
>
> But there wasn't enough confidence in the fix to sent it to you yet, I guess.
>
> The related thread: http://www.spinics.net/lists/linux-mm/msg66972.html

Yes, I'd taken the cowardly approach of scheduling it for 3.14, with a
3.13.x backport.

Nobody answered my question! Is this a new bug or is it a
five-year-old bug which we only just discovered?

I guess it doesn't matter much - we should fix it in 3.13. I'll
include it in the next for-3.13 batch.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/