Re: [PATCH] net: tulip: delete useless tests on netdev_priv

From: David Miller
Date: Fri Jan 03 2014 - 19:35:50 EST


From: Grant Grundler <grantgrundler@xxxxxxxxx>
Date: Thu, 2 Jan 2014 07:57:26 -0800

> On Thu, Jan 2, 2014 at 8:28 AM, Julia Lawall <Julia.Lawall@xxxxxxx> wrote:
>> From: Julia Lawall <Julia.Lawall@xxxxxxx>
>>
>> Netdev_priv performs an addition, not a pointer dereference, so it seems
>> quit unlikely that its result would ever be NULL.
>
> LGTM.
>
> >
>> A semantic patch that makes this change is as follows:
>> (http://coccinelle.lip6.fr/)
>>
>> // <smpl>
>> @@
>> statement S;
>> @@
>>
>> - if (!netdev_priv(...)) S
>> // </smpl>
>>
>> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
>
> Acked-by: Grant Grundler <grundler@xxxxxxxxxxxxxxxx>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/