Re: [PATCH net-next] r8152: fix the wrong return value

From: David Miller
Date: Fri Jan 03 2014 - 20:38:14 EST


From: Hayes Wang <hayeswang@xxxxxxxxxxx>
Date: Fri, 3 Jan 2014 11:21:56 +0800

> The return value should be the boolean value, not the error code.
>
> Signed-off-by: Hayes Wang <hayeswang@xxxxxxxxxxx>
> Spotted-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Applied, but I agree with others that it's more canonical to have the
function return either an error code, or zero for success, rather than
a boolean.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/