Re: [dm-devel] [PATCH] kobject: provide kobject_put_wait to fixmodule unload race

From: Greg Kroah-Hartman
Date: Sun Jan 05 2014 - 13:26:33 EST

On Sun, Jan 05, 2014 at 05:43:56PM +0100, Bart Van Assche wrote:
> On 01/04/14 19:06, Mikulas Patocka wrote:
> > - if (t && !t->release)
> > - pr_debug("kobject: '%s' (%p): does not have a release() "
> > - "function, it is broken and must be fixed.\n",
> > - kobject_name(kobj), kobj);
> > -
> Has it been considered to issue a warning if no release function has
> been defined and free_completion == NULL instead of removing the above
> debug message entirely ? I think even with this patch applied it is
> still wrong to invoke kobject_put() on an object without defining a
> release function.

This patch isn't going to be applied, and I've reverted the original
commit, so there shouldn't be any issues anymore with this code.


greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at