Re: [dm-devel] [PATCH] kobject: provide kobject_put_wait to fixmodule unload race
From: Mikulas Patocka
Date: Sun Jan 05 2014 - 17:05:17 EST
On Sun, 5 Jan 2014, Bart Van Assche wrote:
> On 01/04/14 19:06, Mikulas Patocka wrote:
> > - if (t && !t->release)
> > - pr_debug("kobject: '%s' (%p): does not have a release() "
> > - "function, it is broken and must be fixed.\n",
> > - kobject_name(kobj), kobj);
> > -
> Has it been considered to issue a warning if no release function has
> been defined and free_completion == NULL instead of removing the above
> debug message entirely ? I think even with this patch applied it is
> still wrong to invoke kobject_put() on an object without defining a
> release function.
With the above patch, you don't need the release method for correct
behavior. Therefore you don't have to issue warning when it is missing.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/