Re: [PATCH 2/3] Staging rtl8192e: Fixing checkpatch error inrtllib_debug.h

From: Dan Carpenter
Date: Mon Jan 06 2014 - 03:05:57 EST

On Sun, Jan 05, 2014 at 01:25:36PM +0100, Andreas Frembs wrote:
> In rtllib_debug.h we fixed the following checkpatch error:
> ERROR: Macros with complex values should be enclosed in parenthesis
> We fixed this with a do {} while (0), because otherwise the compiler complained.
> Signed-off-by: Andreas Frembs <andreas.frembs@xxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Matthias Schoepe <matthias.schoepe@xxxxxxxxxxxxxxxxxxxxxxx>

It would be better to replace these with WARN_ON(). I haven't looked
but I also suspect that some of these asserts might be bogus and should
be removed.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at