Re: [PATCH 1/4] tools lib traceevent: Add state member to structtrace_seq

[Steven Rostedt]

On Mon, 6 Jan 2014 15:38:28 +0100
Jiri Olsa <jolsa@xxxxxxxxxx> wrote:


> > I just thought that it's not so important to print message so keeps the
> > error internally until it gets printed.  But I can be wrong as usual...
> 
> I think that if she manages to get one of those errors
> the perf would fail soon anyway.. so it feels better
> to print it out immediately.

Yeah, using a trace_seq after it has been destroyed is a critical
failure, and a major bug. A print to the user console should not be a
problem here. And actually, crashing is not that bad either, as glibc
does the same with using free() of a freed pointer.

But as this error is major, an unwanted print is minor.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/