Re: [PATCH v2 1/7] mfd: Move pm8xxx-irq.c contents into only driverthat uses it

From: Lee Jones
Date: Mon Jan 06 2014 - 09:47:52 EST

On Mon, 23 Dec 2013, Stephen Boyd wrote:

> The pm8xxx-irq.c code is practically mandatory given that the
> pm8921-core driver will WARN about it missing and the Kconfig
> marks it as default y when a PM8xxx chips is enabled. The only
> reason the file was split out was because we planned to support
> other pm8xxx chips with different pm8xxx-core.c files. Now that
> we have DT on ARM this isn't necessary because we should be able
> to support all the ssbi based PM8xxx chips in one driver and one
> file with no data bloat. Let's move this code into the only
> driver that uses it right now (pm8921) so that it's always compiled when
> needed. In the future we can rename pm8921-core.c to something
> more generic.
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>
> ---
> drivers/mfd/Kconfig | 10 --
> drivers/mfd/pm8921-core.c | 348 ++++++++++++++++++++++++++++++++++++++
> drivers/mfd/pm8xxx-irq.c | 371 -----------------------------------------
> include/linux/mfd/pm8xxx/irq.h | 23 ---
> 4 files changed, 348 insertions(+), 404 deletions(-)
> delete mode 100644 drivers/mfd/pm8xxx-irq.c

Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

Lee Jones
Linaro STMicroelectronics Landing Team Lead â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at