Re: [PATCH 0/2] tracing/triggers: A couple minor variable namechanges
From: Tom Zanussi
Date: Mon Jan 06 2014 - 21:51:15 EST
> > > + enum event_trigger_type tt = ETT_NONE;
> > > +
> > > + if (__event_trigger_test_discard(file, buffer, event, entry, &tt))
> > > + trace_buffer_unlock_commit(buffer, event, irq_flags, pc);
> > The logic is correct overall, but the way it reads is the opposite of
> > what it used to i.e. it should read 'if you don't discard the event,
> > then do the trace_buffer_unlock_commit' - it works as written because it
> > returns 1 if it didn't discard, which is confusing.
> Hmm, OK, I think you may have convinced me. I'll swap the return values.
Sounds great, thanks!
> I need to write up some trigger tests to make sure they work the same
> before and after this patch.
I'll run the next version through my 'testsuite', which unfortunately is
still manual (one of the many things on my todo list is automate it)..
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/