Re: [PATCH net 2/2] net: core: explicitly select a txq before doingl2 forwarding

[John Fastabend]

[...]

> > +int dfwd_direct_xmit(struct sk_buff *skb, struct net_device *dev,
> > +             void *accel_priv)
> > +{
> > +    struct netdev_queue *txq;
> > +    int ret = NETDEV_TX_BUSY;
> > +    int index;
> > +
> > +    BUG_ON(!dev->netdev_ops->ndo_dfwd_select_queue);
> > +    index =    dev->netdev_ops->ndo_dfwd_select_queue(dev, skb,
> > +                               accel_priv);
> > +
> > +    local_bh_disable();
> > +
> > +    skb_set_queue_mapping(skb, index);
>
> How about replacing the index calculation and skb_set_queue_mapping with
> netdev_pick_tx(). Then we don't need to add a new op and the existing
> XPS, tx hash and select_queue() op works.

Sorry for the noise that was dumb it wouldn't work.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/