Re: [PATCH 82/85] drivers: gpu: Mark functions as static invmwgfx_kms.c

[Josh Triplett]

On Tue, Jan 07, 2014 at 11:21:12AM +0100, Jakob Bornecrantz wrote:
> On Mon, Jan 6, 2014 at 5:48 PM, Rashika Kheria <rashika.kheria@xxxxxxxxx> wrote:
> > Mark functions as static because they are not used outside the file
> > drm/vmwgfx/vmwgfx_kms.c.
> >
> > This eliminates the following warnings in drm/vmwgfx/vmwgfx_kms.c:
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:43:6: warning: no previous prototype for âvmw_clip_cliprectsâ [-Wmissing-prototypes]
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:426:6: warning: no previous prototype for âvmw_framebuffer_surface_destroyâ [-Wmissing-prototypes]
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:592:5: warning: no previous prototype for âvmw_framebuffer_surface_dirtyâ [-Wmissing-prototypes]
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:757:6: warning: no previous prototype for âvmw_framebuffer_dmabuf_destroyâ [-Wmissing-prototypes]
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:943:5: warning: no previous prototype for âvmw_framebuffer_dmabuf_dirtyâ [-Wmissing-prototypes]
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:1666:5: warning: no previous prototype for âvmw_du_update_layoutâ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
> > Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/vmwgfx/vmwgfx_kms.c |   12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> 
> This and patch 83, 84, 85 are
> Reviewed-by: Jakob Bornecrantz <jakob@xxxxxxxxxx>

Can you take them through your tree, or are you expecting them to follow
another path?

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/