Re: [PATCH 4/4] drm/i915: check LVDS for EDID on GPU switches

[Ramkumar Ramachandra]

Chris Wilson wrote:
> On Tue, Jan 07, 2014 at 03:28:43PM +0530, Ramkumar Ramachandra wrote:
>> If the LVDS panel wasn't connected at boot then we won't have an EDID
>> for it. To fix this, call intel_lvds_get_edid() from the vga_switcheroo
>> reprobe callback.
>
> I would rather have an iterator over all our connectors (or perhaps
> encoders would be the right semantic, except we have
> connectors==encoders) and a reprobe callback.

I don't follow; iterate over which connectors? There's one
lvds_connector for which we get EDID.

> Saves exporting private
> functions and prevent me asking silly questions like what about eDP?

Avoid exporting intel_lvds_get_edid()? Why?

p.s- Excuse the stupidity of the questions; I know close to nothing
about how i915 or switcheroo work.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/