Re: [PATCH v2] dma-debug: enhance dma_debug_device_change() to checkfor mapping errors

[Shuah Khan]

On 01/07/2014 07:26 AM, Joerg Roedel wrote:
> On Fri, Jan 03, 2014 at 11:26:04AM -0700, Shuah Khan wrote:
> > On 12/30/2013 07:15 AM, Joerg Roedel wrote:
> > > I think it is better to check for this in a seperate function and use
> > > err_printk instead of dev_warn in the end to print the errors.
> > > The new function can then be called in the dma_debug_device_change
> > > callback like device_dma_allocations is.
> >
> > I did explore separate function option and backed off from it since
> > the new routine will have to duplicate what device_dma_allocations()
> > does except that it checks for entry->map_err_type.
> >
> > I still have the patch that does that saved away. If you still
> > prefer that approach, I can rework the patch and send it.
>
> You can get rid of the code duplication by defining for_each macros for
> the list traversals. So I would still prefer to have this check in a
> seperate function.
>
>
> 	Joerg

Joerg,

This patch and a follow-on cocinelli warning fix patch are in 
linux-next. Would you like me to send a patch relative to the change in 
linux-next or cut a new patch against the latest Linus's git. I can go 
either way. We just have to remember to drop those two patches from 
linux-next.

-- Shuah

--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@xxxxxxxxxxx | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/