Re: [PATCH] ASoC: soc-core: add snd_soc_of_parse_sysclk_id() for dt

From: Mark Brown
Date: Tue Jan 07 2014 - 11:25:12 EST


On Thu, Jan 02, 2014 at 03:34:17PM +0800, Xiubo Li wrote:
> This patch adds snd_soc_of_parse_sysclk_id() and supports below
> style on dt:
>
> sysclk-id = <XXX>;
>
> It's an optional property, If this property is absent the defualt
> vaule 0 will be returned.

The trick with this is defining what the clock should be. Drivers would
have to start defining their clock IDs and then at some point we end up
reinventing the common clock API and bindings. We really ought to be
moving ASoC's clock handling over towards clk but there's issues with
that given that the clock API is not available at all on some platforms
and the common clock API isn't common. This is rather a larger bit of
work than I expect you want to do right now though...

What's your use case for this - is it possible to make the driver you're
looking at default to a clock that'll work for most systems? That'd
sidestep the need to say which clock. Alternatively is the CODEC only
likely to be used with systems supporting common clk in which case doing
the sysclk configuration via the clk API might be the way forwards?

Attachment: signature.asc
Description: Digital signature