Re: [PATCH V2] leds: s3c24xx: Fix build failure

From: Linus Walleij
Date: Tue Jan 07 2014 - 12:42:06 EST

On Fri, Jan 3, 2014 at 7:19 AM, Bryan Wu <cooloney@xxxxxxxxx> wrote:
> On Thu, Jan 2, 2014 at 9:25 PM, Tushar Behera <tushar.behera@xxxxxxxxxx> wrote:
>> Commit c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>")
>> removed the usage of mach/gpio.h file, but we need to include
>> plat/gpio-cfg.h to avoid following build error.
>> Fixes following build error.
>> drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
>> function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
> I think this patch should go with Linus's patchset.

Patch applied to the GPIO tree. I added your ACK Bryan since
that seems to be implied above ...

Linus Walleij
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at