Re: [PATCH] drm/msm: Fix link error with !MSM_IOMMU

From: Joerg Roedel
Date: Tue Jan 07 2014 - 17:53:58 EST


On Tue, Jan 07, 2014 at 11:47:26PM +0100, Joerg Roedel wrote:
> The DRM driver for MSM depends on symbols from the MSM
> IOMMU driver. Add this dependency to the Kconfig file.
>
> Fixes this comile error:
>
> Kernel: arch/arm/boot/zImage is ready
> ERROR: "msm_iommu_get_ctx" [drivers/gpu/drm/msm/msm.ko]
> undefined!
> make[2]: *** [__modpost] Error 1
>
> Cc: Rob Clark <robdclark@xxxxxxxxx>
> Signed-off-by: Joerg Roedel <joro@xxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index f39ab75..d3de8e1 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -4,6 +4,7 @@ config DRM_MSM
> depends on DRM
> depends on ARCH_MSM
> depends on ARCH_MSM8960
> + depends on MSM_IOMMU
> select DRM_KMS_HELPER
> select SHMEM
> select TMPFS

FYI, I put the patch to my arm/msm branch meanwhile to get the build
error fixed. Please let me know when there is another solution merged
and I will drop it.


Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/