Re: [PATCH net-next v3 1/9] xen-netback: Introduce TX grant map definitions

[Zoltan Kiss]

On 08/01/14 01:29, David Miller wrote:
> > +static inline int tx_dealloc_work_todo(struct xenvif *vif)
>
> Make this return bool.
Done, also in the last patch.

> > +		wait_event_interruptible(vif->dealloc_wq,
> > +					tx_dealloc_work_todo(vif) ||
> > +					 kthread_should_stop());
>
> Inconsistent indentation.  You should make the arguments line up at
> exactly the first column after the openning parenthesis of the function
> call.
Done, thanks.

Zoli

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/