Re: [PATCH 1/4] ASoC: simple-card: add simple audio card widgetssupport

[Mark Brown]

On Wed, Jan 08, 2014 at 03:02:33PM +0800, Xiubo Li wrote:
> For many audio cards there need to add some off-CODEC widgets, and this
> is hard to be supported by dts only, because maybe some widgets need one
> or more call backs, such as wevent.

The big question here would be why these widgets need to be added - the
default thing is that all inputs and outputs are enabled so it can't be
that and as you say callbacks are going to need to be added.

If this is used then it probably makes sense for the card to set the
fully routed flag since one possible use is to disable unconnected pins
on the CODEC.

> +- simple-sudio-card,widgets		: The name of the audio card off-CODEC widgets.

simple-audio-card.  This also needs more documentation about what is
supposed to be filled in here.

> +void
> +asoc_simple_card_widgets_unregister(struct asoc_simple_card_widgets *comp)

We always use snd_soc.

One interesting thing here is that this is done separately to the card
itself.  Is there any actual dependency on the simple card, could this
be made into a generic library that any machine driver could use?  I can
see other machines being able to make use of this.

Attachment: signature.asc
Description: Digital signature