Re: [PATCH] vt: initialize con_driver->node in con_init

From: Greg KH
Date: Wed Jan 08 2014 - 23:33:25 EST


On Mon, Dec 30, 2013 at 11:11:02AM +0800, Wang YanQing wrote:
> Commit 6db4063c5b72b46e9793b0f141a7a3984ac6facf
> ("[PATCH] VT binding: Add sysfs control to the VT layer")
> add node item into struct con_driver.

That patch was from 2006. Why is this change needed now, what problems
happen without your fix below?

thanks,

greg k-h

>
> This patch initialize con_driver->node in con_init.
>
> Signed-off-by: Wang YanQing <udknight@xxxxxxxxx>
> ---
> drivers/tty/vt/vt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index edcd6b8..9adb4e0 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -2879,6 +2879,7 @@ static int __init con_init(void)
> if (con_driver->con == NULL) {
> con_driver->con = conswitchp;
> con_driver->desc = display_desc;
> + con_driver->node = i;
> con_driver->flag = CON_DRIVER_FLAG_INIT;
> con_driver->first = 0;
> con_driver->last = MAX_NR_CONSOLES - 1;
> --
> 1.8.3.4.8.g69490f3.dirty
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/