Re: [PATCH 2/5] ARM: kprobes-test: use <asm/opcodes.h> forinstruction accesses

From: Taras Kondratiuk
Date: Thu Jan 09 2014 - 05:55:09 EST


On 3 January 2014 17:53, Jon Medhurst (Tixy) <tixy@xxxxxxxxxx> wrote:
> On Mon, 2013-12-23 at 18:19 +0200, Taras Kondratiuk wrote:
>> From: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
>>
>> Ensure we read instructions in the correct endian-ness by using
>> the <asm/opcodes.h> helper to transform them as necessary.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
>> [taras.kondratiuk@xxxxxxxxxx: fix next_instruction() function]
>> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@xxxxxxxxxx>
>> ---
>
> Apart from the spurious line removal (see below) then:
>
> Acked-by: Jon Medhurst <tixy@xxxxxxxxxx>
>
> and you can include an ACK for the other patches in this series too.
>
> Thanks.

>> @@ -1593,7 +1594,6 @@ static int run_test_cases(void (*tests)(void), const union decode_item *table)
>> return 0;
>> }
>>
>> -
>
> I know the above blank line isn't needed but I believe the convention is
> to avoid doing unrelated white-space clean-ups in patches.

Right, I will remove it.
Should this series go through Russell's patch tracking system or it
can be pulled
to some tree?

--
Regards,
Taras Kondratiuk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/