Re: [PATCH] ASoC: simple-card: fix a bug where cinfo will be NULLbefore using it

From: Mark Brown
Date: Thu Jan 09 2014 - 12:37:54 EST


On Thu, Jan 09, 2014 at 05:19:08PM +0800, Xiubo Li wrote:

> } else {
> - cinfo->snd_card.dev = &pdev->dev;
> cinfo = pdev->dev.platform_data;
> + cinfo->snd_card.dev = &pdev->dev;
> }

I've applied this since not crashing is good but it's a bug to be
writing to the platform data at all, it should be constant. If it needs
to be written to a copy should be being used.

Attachment: signature.asc
Description: Digital signature