RE: [PATCH 1/1] Drivers: hv: Implement the file copy service

[KY Srinivasan]

> -----Original Message-----
> From: Olaf Hering [mailto:olaf@xxxxxxxxx]
> Sent: Thursday, January 09, 2014 4:04 AM
> To: KY Srinivasan
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxxxxxxxxxxxxxx; apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx
> Subject: Re: [PATCH 1/1] Drivers: hv: Implement the file copy service
> 
> On Wed, Jan 08, K. Y. Srinivasan wrote:
> 
> > +++ b/tools/hv/hv_fcopy_daemon.c
> 
> > +		len = pread(fcopy_fd, buffer, (4096 * 2), 0);
> > +
> > +		if (len <= 0) {
> > +			syslog(LOG_ERR, "Read error: %s\n", strerror(errno));
> > +			continue;
> 
> This could flood syslog. I think the error should be logged just once.
> Maybe like this:
> 
>         if (len <=0) {
>                 if (!error) {
>                         syslog(...);
>                         error = HV_ERROR_NOT_SUPPORTED;
>                 }
>                 continue;
>         }
> 
> > +		}
> > +		in_msg = (struct hv_fcopy_hdr *)buffer;
> > +
> > +		switch (in_msg->operation) {
> > +		case START_FILE_COPY:
> > +			error = hv_start_fcopy((struct hv_start_fcopy *)in_msg);

Will do. 

K. Y
> 
> Olaf
¢éì®&Þ~º&¶¬–+-±éÝ¥Šw®žË±Êâmébžìdz¹Þ)í…æèw*jg¬±¨¶‰šŽŠÝj/êäz¹ÞŠà2ŠÞ¨è­Ú&¢)ß«a¶Úþø®G«éh®æj:+v‰¨Šwè†Ù>Wš±êÞiÛaxPjØm¶ŸÿÃ-»+ƒùdš_