Re: [PATCH 09/14] target/configfs: Expose protection deviceattributes

[Nicholas A. Bellinger]

On Thu, 2014-01-09 at 13:01 +0200, Sagi Grimberg wrote:
> On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx>
> >
> > This patch adds support for exposing DIF protection device
> > attributes via configfs.  This includes:
> >
> >     pi_prot_type: Protection Type (0, 1, 3 currently support)
> >     pi_prot_version: Protection Version (DIF v1 currently supported)
> >     pi_guard_type: Guard Type (1=DIF CRC, 2=IP CRC)
> >
> > Within se_dev_set_pi_prot_type() it also adds the se_subsystem_api
> > device callbacks to setup per device protection information.
> 
> Suggestion, expose pi_prot_format and call transport->init_prot() there. 
> It is more explicit
> and this routine should be called upon getting FORMAT_UNIT as well.

<nod>, working on this next for FILEIO following your original example
code.

Thanks Sagi!

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/