Re: [PATCH v2] ARM: OMAPFB: panel-sony-acx565akm: fix missing mutexunlocks

[Ivaylo Dimitrov]

On 10.01.2014 12:56, Tomi Valkeinen wrote:
> On 2014-01-05 15:13, Ivaylo Dimitrov wrote:
> > From: Ivaylo Dimitrov <freemangordon@xxxxxx>
> >
> > Commit c37dd677988ca50bc8bc60ab5ab053720583c168 fixes the unbalanced
> > unlock in acx565akm_enable but introduces another problem - if
> > acx565akm_panel_power_on exits early, the mutex is not unlocked. Fix
> > that by unlocking the mutex on early return. Also add mutex protection in
> > acx565akm_panel_power_off and remove an unused variable
>
> I think this is just getting more messy. How about we more or less revert the c37dd677988ca50bc8bc60ab5ab053720583c168 and fix it like this:

I am fine with whatever patch you may come with, as long as it fixes the 
issue.

> diff --git a/drivers/video/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/omap2/displays-new/panel-sony-acx565akm.c
> index 714ee92dfb9f..8e97d06921ff 100644
> --- a/drivers/video/omap2/displays-new/panel-sony-acx565akm.c
> +++ b/drivers/video/omap2/displays-new/panel-sony-acx565akm.c

The patch does not apply cleanly on top of rc7, however I applied it by 
hand. So far it seems it fixes the issue brought by 
c37dd677988ca50bc8bc60ab5ab053720583c168, though I didn't test if 
mutex_lock/mutex_unlock are complementary in every code path (at least 
not explicitly, I guess maemo is doing it for us anyway :) ).

So, shall I send a patch incorporating your code changes, or you will do it?

Regards,
Ivo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/