Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE hasdone hw_param

From: Mark Brown
Date: Sat Jan 11 2014 - 07:08:53 EST


On Sat, Jan 11, 2014 at 10:35:33AM +0100, Takashi Iwai wrote:

> But, the point is that basically we already know that something is
> wrong at the point BE2 setting up an incompatible hw_params; then it
> should be notified properly to FE1, or the incompatible change must be
> handled as an error. This is the missing piece in the current
> implementation. The skip of redundant BE hw_params call can be
> implemented as an optimization in this compatibility check, too.

Only in the case where they actually are incompatible though - if
there's DSP in place which can do suitable mixing it's not an issue.
At the minute the core is relying on the drivers handling any limits
just like with the CODECs.

Attachment: signature.asc
Description: Digital signature