Re: [PATCH] arch/avr32/boards/mimc200/fram.c: add missing 'module.h'for MODULE_LICENSE

From: Hans-Christian Egtvedt
Date: Sun Jan 12 2014 - 12:16:21 EST


Around Fri 10 Jan 2014 11:16:14 +0300 or thereabout, Sergei Trofimovich wrote:
> config: make ARCH=avr32 mimc200_defconfig
>
>> All error/warnings:
>>
>> arch/avr32/boards/mimc200/fram.c:79: error: expected declaration specifiers or '...' before string constant
>> arch/avr32/boards/mimc200/fram.c:79: warning: data definition has no type or storage class
>> arch/avr32/boards/mimc200/fram.c:79: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
>> >> arch/avr32/boards/mimc200/fram.c:79: error: function declaration isn't a prototype
>
> Untested.

Looks very sane.

> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
> CC: Mark Jackson <mpfj@xxxxxxxxxx>
> CC: Hans-Christian Egtvedt <egtvedt@xxxxxxxxxxxx>
> CC: Haavard Skinnemoen <haavard.skinnemoen@xxxxxxxxx>
> Signed-off-by: Sergei Trofimovich <slyfox@xxxxxxxxxx>

Acked-by: Hans-Christian Egtvedt <egtvedt@xxxxxxxxxxxx>

> ---
> arch/avr32/boards/mimc200/fram.c | 1 +
> 1 file changed, 1 insertion(+)

I will append this to the AVR32 tree at git.kernel.org.

> diff --git a/arch/avr32/boards/mimc200/fram.c b/arch/avr32/boards/mimc200/fram.c
> index 9764a1a..76cb51d 100644
> --- a/arch/avr32/boards/mimc200/fram.c
> +++ b/arch/avr32/boards/mimc200/fram.c
> @@ -13,6 +13,7 @@
> #include <linux/miscdevice.h>
> #include <linux/proc_fs.h>
> #include <linux/mm.h>
> +#include <linux/module.h>
> #include <linux/io.h>
>
> #define FRAM_BASE 0xac000000
--
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/