Re: [PATCH 1/1] lockdep: Kill held_lock->check and "int check" argof __lock_acquire()

[Dave Jones]

On Sun, Jan 12, 2014 at 06:45:54PM +0100, Oleg Nesterov wrote:
 
 > diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
 > index 92b1bfc..13bd13d 100644
 > --- a/include/linux/lockdep.h
 > +++ b/include/linux/lockdep.h
 > @@ -252,7 +252,6 @@ struct held_lock {
 >  	unsigned int trylock:1;						/* 16 bits */
 >  
 >  	unsigned int read:2;        /* see lock_acquire() comment */
 > -	unsigned int check:2;       /* see lock_acquire() comment */
 >  	unsigned int hardirqs_off:1;
 >  	unsigned int references:11;					/* 32 bits */

The 'bits' comments seem to be crap, even before your patch.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/