[PATCH 4/4] staging: tidspbridge: delete useless variable

From: Julia Lawall
Date: Mon Jan 13 2014 - 10:22:47 EST


From: Julia Lawall <Julia.Lawall@xxxxxxx>

The variable status is initialized to either 0 or an error code. Return
status to propagate the error value.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
type T;
identifier i;
constant c;
@@

-T i;
<... when != i
-i = c;
...>
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>

---
Most remove functions only return 0, as this one did before the change. So
perhaps the correct solution is to remove the status variable?

drivers/staging/tidspbridge/rmgr/drv_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c b/drivers/staging/tidspbridge/rmgr/drv_interface.c
index cafca46..74d31da 100644
--- a/drivers/staging/tidspbridge/rmgr/drv_interface.c
+++ b/drivers/staging/tidspbridge/rmgr/drv_interface.c
@@ -589,7 +589,7 @@ func_cont:
class_destroy(bridge_class);

}
- return 0;
+ return status;
}

#ifdef CONFIG_PM

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/