Re: [PATCH 2/3] PATCH: UV/NMI Fix tip/bot/kbuild test robot problems

From: Peter Zijlstra
Date: Tue Jan 14 2014 - 08:39:59 EST


On Tue, Jan 14, 2014 at 05:27:46AM -0800, Mike Travis wrote:
>
>
> On 1/14/2014 3:00 AM, Peter Zijlstra wrote:
> > On Mon, Jan 13, 2014 at 10:24:09PM -0600, Mike Travis wrote:
> >> Fix some problems found by the kbuild test robot.
> >>
> >> Signed-off-by: Mike Travis <travis@xxxxxxx>
> >> Reviewed-by: Hedi Berriche <hedi@xxxxxxx>
> >
> > In general it is best to actually mention the issues the patch cures,
> > otherwise review is impossible, /me stares hard at Hedi.
> >
>
> I can send an updated patch if required? The issues were
> pretty trivial so I didn't think more info than the patch
> itself was needed.

It makes it impossible to say if what you did corresponds with what you
meant to do; let alone say if its the 'correct' way.

> Hopefully I don't get a lot more in the future (this was my
> first time), should I include the actual tipbot messages?

Sure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/