Re: [slub] WARNING: CPU: 0 PID: 0 at mm/slub.c:1511__kmem_cache_create()

From: David Rientjes
Date: Tue Jan 14 2014 - 19:36:55 EST


On Tue, 14 Jan 2014, Dave Hansen wrote:

> > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=c65c1877bd6826ce0d9713d76e30a7bed8e49f38
>
> I think the assert is just bogus at least in the early case.
> early_kmem_cache_node_alloc() says:
> * No kmalloc_node yet so do it by hand. We know that this is the first
> * slab on the node for this slabcache. There are no concurrent accesses
> * possible.
>
> Should we do something like the attached patch? (very lightly tested)
>

Yeah, I think that's the best option to keep the runtime checking to
ensure the proper lock is held on debug kernels with lockdep enabled and
is better than reverting back to the comment.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/