Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump anarbitrary pagetable

[Dave Young]

On 01/14/14 at 10:18am, H. Peter Anvin wrote:
> On 01/13/2014 05:40 PM, Dave Young wrote:
> > On 01/13/14 at 06:48am, Arjan van de Ven wrote:
> >> On 1/13/2014 4:23 AM, Dave Young wrote:
> >>>>
> >>>>> How about do not limit to only if (pgd) case, instead do something
> >>>>> like below: set dump_to_dmesg as a module parameter
> >>>>
> >>>> X86_PTDUMP is not a module.
> >>>
> >>> Hmm, I just see the module macros in the code, since it's a bool Kconfig
> >>> I think the dump_pagetables.c need a cleanup,
> >>> remove the #include <linux/module.h> and below lines:
> >>> MODULE_LICENSE("GPL");
> >>> MODULE_AUTHOR("Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>");
> >>> MODULE_DESCRIPTION("Kernel debugging helper that dumps pagetables");
> >>
> >> personally I consider it good form to always have this kind of information in .c files,
> >> regardless of the KConfig side of thing...
> > 
> > I agree it's good to add these infomation, but they can be added in comment.
> > IMHO it will be better in that way.
> > 
> 
> Why the [Finnish] do you feel that information needs to be in a
> different form because it is (currently!) not available as a module?

I think moving them to comment can avoid including extra linux/module.h

If a module specific parameter is needed maybe it's not bad to add dummy
module_init/module_exit

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/